FTWD - MIA - RAFAEL GUASP - LAB | Javascript basic algorithms#310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

rguasp wants to merge2 commits intoironhack-labs:masterfromrguasp:master

Closed

FTWD - MIA - RAFAEL GUASP - LAB | Javascript basic algorithms#310

rguasp wants to merge2 commits intoironhack-labs:masterfromrguasp:master

Conversation

Copy link

rguasp commentedApr 3, 2018

No description provided.

rguasp added2 commits

April 3, 2018 13:03

done

79f4bfe

done

56f2753

ianizaguirre reviewed

Apr 11, 2018

View reviewed changes

starter-code/src/functions-and-arrays.js

		}
		}
		console.log(longestWord);
		if(longestWord.length === 0){

Copy link

ianizaguirreApr 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You did not need to make an if statement for "undefined"...
If you would have just just changed line 29 to let longestWord = words[0]; , then you could have done this:

functionfindLongestWord(words){letlongestWord=words[0];for(i=0;i<words.length;i++){if(words[i].length>longestWord.length){longestWord=words[i];}}returnlongestWord;}varlongest=findLongestWord(words);console.log(longest);

Copy link

ianizaguirre commentedApr 11, 2018

Try to apply this feedback on your next project.
If you have any questions on my feedback, just send me a message on Slack.
Aside from that, good job and keep up the good work! 😁

Kind Regards,
Ian Izaguirre | Ironhack TA