Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

stuart-gardner, thomas-beguin#117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

stuartogardner
Copy link

No description provided.

// Unique Arrays

function uniquifyArray (array) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You are trying to remove duplicates from the array. This approach is very hard. An easier one would be to create a new array in which you add elements you haven't seen before.

Copy link

@yacinehmitoyacinehmito left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work overall. I like that your reused previous functions when possible.

My biggest gripe is the formatting. You need to uncomment most of the code and tidy up the indentation. I am going to approve your work once you've done this little fix ;)

@posvaposva closed thisSep 6, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@yacinehmitoyacinehmitoyacinehmito requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@stuartogardner@yacinehmito@posva

[8]ページ先頭

©2009-2025 Movatter.jp