Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Johnny Burke, Kiyohide Hayashi - Berlin - W1D1 Lab#609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
JohnnyAL wants to merge1 commit intoironhack-labs:masterfromJohnnyAL:master

Conversation

@JohnnyAL
Copy link

No description provided.

console.log(`The driver's name is${hacker1}`);
lethacker2="Kiyo";
console.log(`The navigator's name is${hacker2}`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice job! No comments on this iteration

}else{
console.log(`It seems that the navigator has the longest name, it has${hacker2.length} characters.`);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice job as well here! All good
On a small note, on the conditionals, try to leave the else condition for the "===" in this case, and the other if statements for the "<" and ">" options. As I said the code is still good but it could be more readable for other partners the other way.

}

console.log(navNameReverse);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All good in this iteration!
No comments :D

console.log("Yo, the navigator goes first definitely.");
}else{
console.log("What?! You both have the same name?");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All good as well here!
No comments! :D

@stale
Copy link

stalebot commentedFeb 6, 2020

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the stale labelFeb 6, 2020
@stale
Copy link

stalebot commentedFeb 8, 2020

This pull request is closed. Thank you.

@stalestalebot closed thisFeb 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@fonsogmsfonsogmsfonsogms left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohnnyAL@fonsogms

[8]ページ先頭

©2009-2025 Movatter.jp