- Notifications
You must be signed in to change notification settings - Fork1
feat: add SessionExchange support and optimize blocking checks#50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
lidel wants to merge5 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- implement BlockedBlockstore wrapper for blockstore operations- implement BlockedExchange with SessionExchange support- add BlockedFetcher for session-level blocking- optimize BlockService to delegate checks to wrapped components- add compile-time type assertions for all interfacesfixes#34
lidel added a commit to ipfs/boxo that referenced this pull requestAug 31, 2025
- use blockservice.NewSession for automatic session reuse- properly enforce denylist checks via wrapped blockstore/exchange- improve performance with request-level session batchingrequiresipfs-shipyard/nopfs#50fixes#458fixesipfs/kubo#10361
lidel added a commit to ipfs/kubo that referenced this pull requestAug 31, 2025
- nopfs: SessionExchange support and optimized blocking checksipfs-shipyard/nopfs#50- boxo: restored session usage in CAR streaming with proper blockingipfs/boxo#1019fixes#10361
- test blockstore, exchange, and blockservice wrappers- add test helpers and mocks
plugin is now built into kubo v0.24.0+
- include ipfs/ tests in CI workflow- update to go 1.24 for compatibility
c8da810 to16ea529CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Warning
This wip experimentation, not ready for review yet.
This PR aims to address problem from#34 and also..
BlockedBlockstorewrapper for blockstore operationsBlockedExchangewithSessionExchangesupportBlockedFetcherfor session-level blockingBlockServiceto delegate checks to wrapped componentsI'm mainly depending on e2e tests in Kubo (
go test -v ./test/cli -run "TestContentBlocking") in PR that integrates this PR andipfs/boxo#1019