Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(core): use Capacitor's new safe area variables#30865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
thetaPC wants to merge11 commits intomain
base:main
Choose a base branch
Loading
fromFW-6987

Conversation

@thetaPC
Copy link
Contributor

@thetaPCthetaPC commentedDec 12, 2025•
edited
Loading

Issue number: internal

What is the current behavior?

The safe area variables are only reliant onenv variables that are provided by devices.

What is the new behavior?

Capacitor 8 has releasedsafe area variable fallbacks to provide consistent behaviors with older Android devices:

Due to abug in some older versions of Android WebView (< 140), correct safe area values are not available via the safe-area-inset-x CSS env variables. This plugin will inject the correct inset values into a new CSS variable(s) named --safe-area-inset-x that you can use as a fallback in your frontend styles.

  • Updated safe area variables to use the fallbacks provided by Capacitor.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build:8.7.13-dev.11765920447.1a01ab8b

@vercel
Copy link

vercelbot commentedDec 12, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
ionic-frameworkReadyReadyPreview,CommentDec 16, 2025 9:56pm

@github-actionsgithub-actionsbot added the package: core@ionic/core package labelDec 12, 2025
@thetaPCthetaPC marked this pull request as ready for reviewDecember 12, 2025 20:13
@thetaPCthetaPC requested a review froma team as acode ownerDecember 12, 2025 20:13
@thetaPCthetaPC requested a review fromgnbmDecember 12, 2025 20:13
Copy link
Member

@ShaneKShaneK left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me! Excellent work 🎉

Copy link
Member

@brandyscarneybrandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some questions / feedback on tests here.

@thetaPCthetaPC changed the titlerefactor(core): use Capacitor's new safe area variablesfix(core): use Capacitor's new safe area variablesDec 16, 2025
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ShaneKShaneKShaneK approved these changes

@gnbmgnbmAwaiting requested review from gnbmgnbm is a code owner automatically assigned from ionic-team/framework

@brandyscarneybrandyscarneyAwaiting requested review from brandyscarney

Assignees

No one assigned

Labels

package: core@ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thetaPC@ShaneK@brandyscarney
[8]ページ先頭
©2009-2025 Movatter.jp