- Notifications
You must be signed in to change notification settings - Fork13.4k
feat(angular): add booleanAttribute transform to IonItem inputs#30825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Advikkhandelwal wants to merge1 commit intoionic-team:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
feat(angular): add booleanAttribute transform to IonItem inputs#30825
Advikkhandelwal wants to merge1 commit intoionic-team:mainfromAdvikkhandelwal:feat/angular-boolean-attributes
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This change allows using boolean attributes like <ion-item button detail>instead of requiring explicit bindings like <ion-item [button]="true" [detail]="true">.Applied to IonItem's button, detail, and disabled inputs using Angular'sbooleanAttribute transform function.Closesionic-team#30822
Someone is attempting to deploy a commit to theIonic Team onVercel. A member of the Team first needs toauthorize it. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
booleanAttributetransforms for IonItem's boolean inputs, allowing cleaner syntax as requested in#30822.Problem
Currently, Angular developers have to use explicit bindings for boolean attributes:
This generates IDE warnings and is more verbose than the desired syntax.
Solution
Applied Angular's
booleanAttributetransform to IonItem'sbutton,detail, anddisabledinputs. This allows:Changes
@stencil/angular-output-targetfrom^0.10.0to^1.1.1IonItemcomponent in both regular and standalone Angular proxiesbutton,detail, anddisabledfrom@ProxyCmpand@Componentinputs arrays@Input({ transform: booleanAttribute })decorators with getters/settersTesting
✅ Core package builds successfully
✅ Angular package builds successfully
✅ Standalone package builds successfully
✅ All linting checks pass
✅ TypeScript compilation without errors
✅ No breaking changes to existing API
Type of Change
Closes#30822