Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement stream priority feature#321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dmenig wants to merge4 commits intoinducer:main
base:main
Choose a base branch
Loading
fromdmenig:issue_319

Conversation

@dmenig
Copy link

@dmenigdmenig commentedNov 23, 2021
edited
Loading

Solves#319

I'm not exactly sure my work is proper, I'm more a python guy than C++. Can you share your thoughts@inducer please ?

Copy link
Owner

@inducerinducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution, and sorry about the long delay in reviewing this.

Gitlab CI link:https://gitlab.tiker.net/inducer/pycuda/-/commit/c08a582c48d1b28e201adb0b2f5a1adec1f5eef6/pipelines?ref=issue_319

@dmenig
Copy link
Author

Thanks for your contribution, and sorry about the long delay in reviewing this.

Gitlab CI link:https://gitlab.tiker.net/inducer/pycuda/-/commit/c08a582c48d1b28e201adb0b2f5a1adec1f5eef6/pipelines?ref=issue_319

Do you know how to solve this ?

        src/wrapper/wrap_cudadrv.cpp:1202:87: error: no matching function for call to ‘pycudaboost::python::init<unsigned int, int>::init(pycudaboost::python::arg&, pycudaboost::python::arg&)’         1202 |       ("Stream", py::init<unsigned int, int>(py::arg("flags")=0, py::arg("priority")=0))

I tried removing theint arg and am waiting for the CI result but I'm doubtful that is the problem. I'm puzzled.

@inducer
Copy link
Owner

I tried removing the int arg and am waiting for the CI result but I'm doubtful that is the problem. I'm puzzled.

Does it compile for you locally?

@inducer
Copy link
Owner

Pushed to Gitlab for CI, find results viahttps://gitlab.tiker.net/inducer/pycuda/-/commits/issue_319

@inducer
Copy link
Owner

(Pushed once again.)

@dmenig
Copy link
Author

I tried removing the int arg and am waiting for the CI result but I'm doubtful that is the problem. I'm puzzled.

Does it compile for you locally?

I didn't try to do that. I usually use my CI for back and forth. I'll see if I manage to do that.

@dmenig
Copy link
Author

dmenig commentedApr 26, 2022
edited
Loading

I managed to repoduce the CI results on my machine. I think this larger message is interesting :

    src/wrapper/wrap_cudadrv.cpp:1202:87: error: no matching function for call to ‘pycudaboost::python::init<unsigned int, int>::init(pycudaboost::python::arg&, pycudaboost::python::arg&)’       1202 |       ("Stream", py::init<unsigned int, int>(py::arg("flags")=0, py::arg("priority")=0))                                                                                                    |                                                                                       ^                                                                                               In file included from bpl-subset/bpl_subset/boost/python/class.hpp:20,                                                                                                                                         from bpl-subset/bpl_subset/boost/python.hpp:18,                                                                                                                                               from src/cpp/cuda.hpp:36,                                                                                                                                                                     from src/wrapper/wrap_cudadrv.cpp:3:                                          bpl-subset/bpl_subset/boost/python/init.hpp:253:5: note: candidate: ‘template<long unsigned int N> pycudaboost::python::init<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14>::init(const pycudaboost::python::detail::keywords<N>&, const char*)’                                                                                                                            253 |     init(detail::keywords<N> const& kw, char const* doc_ = 0)                                |     ^~~~                                                                                                                                                                              bpl-subset/bpl_subset/boost/python/init.hpp:253:5: note:   template argument deduction/substitution failed:                                                                                   src/wrapper/wrap_cudadrv.cpp:1202:85: note:   cannot convert ‘pycudaboost::python::detail::keywords<1>(((const char*)"priority")).pycudaboost::python::detail::keywords<1>::operator=<int>(0)’ (type ‘pycudaboost::python::arg’ {aka ‘pycudaboost::python::detail::keywords<1>’}) to type ‘const char*’     1202 |       ("Stream", py::init<unsigned int, int>(py::arg("flags")=0, py::arg("priority")=0))          |                                                                      ~~~~~~~~~~~~~~~^~    In file included from bpl-subset/bpl_subset/boost/python/class.hpp:20,                     from bpl-subset/bpl_subset/boost/python.hpp:18,                     from src/cpp/cuda.hpp:36,                     from src/wrapper/wrap_cudadrv.cpp:3:    bpl-subset/bpl_subset/boost/python/init.hpp:244:5: note: candidate: ‘template<long unsigned int N> pycudaboost::python::init<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14>::init(const char*, const pycudaboost::python::detail::keywords<N>&)’      244 |     init(char const* doc_, detail::keywords<N> const& kw)          |     ^~~~    bpl-subset/bpl_subset/boost/python/init.hpp:244:5: note:   template argument deduction/substitution failed:

Looks like I can't supply two keywords with default value to this function, but I can't figure out why. Come to think of it : none of the other functions have two arguments with default values in this repo. Can you tell me how to solve this ?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@inducerinducerinducer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmenig@inducer

[8]ページ先頭

©2009-2025 Movatter.jp