- Notifications
You must be signed in to change notification settings - Fork289
Don't write file if content is identical#899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@henrikno thank you for the PR! very clever solution. Sorry for the delay, I've seen this but only now got a chance to look into. So while I definitely see the benefits, the other side of this is that there should be an impact for any other usage (on this later) as reading the whole files and running them thru equals might have some performance impact that I'm yet to estimate. I'm interested to know the specifics of incremental compilation (was it just javac, or maven, gradle or something else). Is it possible to do this only when incremental compilation is executed? (I know this might be hard to answer) |
0840420 tobf04627Compare82c6c1a to62a83d1Compare
I noticed we were recompiling some modules even without doing any changes, and traced it back to files generated by immutables that changed the mtime of the files. This PR attempts to speed up incremental compiles by not writing the file if the content is already the same.