Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't write file if content is identical#899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
henrikno wants to merge1 commit intoimmutables:master
base:master
Choose a base branch
Loading
fromhenrikno:dont-rewrite-file

Conversation

@henrikno
Copy link

I noticed we were recompiling some modules even without doing any changes, and traced it back to files generated by immutables that changed the mtime of the files. This PR attempts to speed up incremental compiles by not writing the file if the content is already the same.

stevenschlansker reacted with thumbs up emoji
@elucash
Copy link
Member

@henrikno thank you for the PR! very clever solution. Sorry for the delay, I've seen this but only now got a chance to look into. So while I definitely see the benefits, the other side of this is that there should be an impact for any other usage (on this later) as reading the whole files and running them thru equals might have some performance impact that I'm yet to estimate. I'm interested to know the specifics of incremental compilation (was it just javac, or maven, gradle or something else). Is it possible to do this only when incremental compilation is executed? (I know this might be hard to answer)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henrikno@elucash

[8]ページ先頭

©2009-2025 Movatter.jp