Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor#1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
angel-christian25 wants to merge6 commits intoimmutables:master
base:master
Choose a base branch
Loading
fromangel-christian25:refactor

Conversation

@angel-christian25
Copy link

No description provided.

@elucash
Copy link
Member

sorry for the long delays. Because the changes are big it's reasonably hard to say if those are ok. I hoped someone else can look at it, so I don't have to learn this part of the codebase and remember many things from some years ago.
If there's still intention to land this, I can have another deeper look, given the following.

  1. Formatting in many files are disregarded (some other style is introduced in some files, indentation etc, please match to the rest of the code)
  2. Don't extract(move to top level) classes inNaming, no need to do so. Try to provide just minimal factory method if you need some of those and even consider avoiding it, is there really no other way?
  3. It is unclear why move internals ofhasValueOrVirtualFields to encoding? the new method is not used in this PR.
  4. Which tests to rely on to verify that refactoring doesn't change the behavior?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angel-christian25@elucash

[8]ページ先頭

©2009-2025 Movatter.jp