Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork867
Throw when accessing non-draftables in strict mode#715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Gelio wants to merge5 commits intoimmerjs:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
7836fb0 feature: Add strict mode for accessing non-draftables
Gelioc30fef3 Add tests for strict mode
Gelioae6808e Allow using strict mode with ES5 plugin
Gelioadeb53b Add test for non-draftables in a different scope
Gelioc60c592 Reduce the scope of expects in strict-mode tests
GelioFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Add tests for strict mode
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitc30fef3bfefcf1feddb01befad067583e7849b0a
There are no files selected for viewing
106 changes: 106 additions & 0 deletions__tests__/strict-mode.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| "use strict" | ||
| import produce, { | ||
| setStrictMode, | ||
| unsafe, | ||
| immerable, | ||
| enableMapSet | ||
| } from "../src/immer" | ||
| enableMapSet() | ||
| describe("Strict Mode", () => { | ||
| class Foo {} | ||
| describe("by default", () => { | ||
| it("should not throw an error when accessing a non-draftable class instance", () => { | ||
| expect(() => | ||
| produce({instance: new Foo()}, draft => { | ||
| draft.instance.value = 5 | ||
| }) | ||
| ).not.toThrow() | ||
| }) | ||
| }) | ||
| afterAll(() => { | ||
| setStrictMode(false) | ||
| }) | ||
| describe("when disabled", () => { | ||
| beforeEach(() => { | ||
| setStrictMode(false) | ||
| }) | ||
| it("should allow accessing a non-draftable class instance", () => { | ||
| expect(() => | ||
| produce({instance: new Foo()}, draft => { | ||
| draft.instance.value = 5 | ||
| }) | ||
| ).not.toThrow() | ||
| }) | ||
| it("should not throw errors when using the `unsafe` function", () => { | ||
| expect(() => | ||
| produce({instance: new Foo()}, draft => { | ||
| unsafe(() => { | ||
| draft.instance.value = 5 | ||
| }) | ||
| }) | ||
| ).not.toThrow() | ||
| }) | ||
| }) | ||
| describe("when enabled", () => { | ||
| beforeEach(() => { | ||
| setStrictMode(true) | ||
| }) | ||
| it("should throw an error when accessing a non-draftable class instance", () => { | ||
| expect(() => | ||
| produce({instance: new Foo()}, draft => { | ||
| draft.instance | ||
| }) | ||
| ).toThrow() | ||
| }) | ||
| it("should allow accessing a non-draftable using the `unsafe` function", () => { | ||
| expect(() => | ||
| produce({instance: new Foo()}, draft => { | ||
| unsafe(() => { | ||
| draft.instance.value = 5 | ||
| }) | ||
| }) | ||
| ).not.toThrow() | ||
| }) | ||
| describe("with an immerable class", () => { | ||
| beforeAll(() => { | ||
| Foo[immerable] = true | ||
| }) | ||
| afterAll(() => { | ||
| Foo[immerable] = true | ||
| }) | ||
| it("should allow accessing the class instance", () => { | ||
| expect(() => | ||
| produce({instance: new Foo()}, draft => { | ||
| draft.instance.value = 5 | ||
| }) | ||
| ).not.toThrow() | ||
| }) | ||
| }) | ||
| it("should allow accessing draftable properties", () => { | ||
| expect(() => | ||
| produce({arr: [], obj: {}, map: new Map(), set: new Set()}, draft => { | ||
| draft.arr.push(1) | ||
| draft.arr[0] = 1 | ||
| draft.obj.foo = 5 | ||
| draft.obj.hasOwnProperty("abc") | ||
| draft.map.set("foo", 5) | ||
| draft.set.add("foo") | ||
| }) | ||
| ).not.toThrow() | ||
| }) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.