Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork866
Faster iteration experiment#1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
FWIW, I've actually been doing some RTK perf optimizations over inreduxjs/redux-toolkit#4361 (comment) , and found that 1) it was faster to do some reads on a |
See also#1107. There are several ways to make Immer quite a bit faster, but it would required much more loosely treating things that have getters/ non-enumerables / symbolic properties, which would benefit the majority of the user base, but also create enough failure scenarios to flood the issue tracker😅 |
@mweststrate out of curiosity, how much of a perf difference do you think this will make? FWIW it looks like onlyone test failed: |
@Pyaepyae-art please stop randomly approving draft or merged PRs. I'm not sure why you are doing this. I hope it is unintentional. But just in case, on the next contextless review you will be banned from the repo. |
Uh oh!
There was an error while loading.Please reload this page.
Object.keys is faster than Reflect.keys. Can we leverage this somehow? (at the cost of symbol props etc)https://www.measurethat.net/Benchmarks/Show/18717/0/reflectownkeys-vs-objectkeys-preformence#latest_results_block