Create count_pair_with_given_sum.cpp#83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Tusharr0305 wants to merge1 commit intoignacio-chiazzo:master

base:master

Choose a base branch

fromTusharr0305:patch-1

Open

Create count_pair_with_given_sum.cpp#83

Tusharr0305 wants to merge1 commit intoignacio-chiazzo:masterfromTusharr0305:patch-1

Conversation

Copy link

Tusharr0305 commentedOct 29, 2022

Added Subarray problem

Create count_pair_with_given_sum.cpp

59e8d6d

Added Subarray problem

ignacio-chiazzo reviewed

Oct 29, 2022

View reviewed changes

Copy link

Owner

ignacio-chiazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Thanks for contributing!

This repository is only for solutions in Javascript. We are also following aspecific format.

I'd be happy to accept this problem but in Javascript.

Thanks again for contributing.

hot9cups requested changes

Oct 30, 2022

View reviewed changes

Copy link

Collaborator

hot9cups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Additionally to what Ignacio mentioned, I would also request a change in the solution when you do translate to javascript.
You have an O(N^2) solution, but I believe you can achieve an O(N) solution using a Map/Dictionary that stores the frequency of every number in the array, and then traversing the map to get count of pairs.