- Notifications
You must be signed in to change notification settings - Fork539
Rename ConTextTab -> sap-rpt-1-oss#1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@MaxSchambach, changes looks good to me. Before merging this PR, could you address the comment + addsap-rpt-1-oss as library_name inhttps://huggingface.co/SAP/sap-rpt-1-oss ? Once that's done, I'll merge and make a release
| prettyLabel:"ConTextTab", | ||
| repoName:"ConTextTab", | ||
| repoUrl:"https://github.com/SAP-samples/contexttab", | ||
| "sap-rpt-1-oss":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you move the entry down in the mapping to keep alphabetical order? (betweensample-factory andsapiens)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 thanks! I've reordered and updated the library name in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perfect, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Anything else that needs resolving? I see some pipeline steps failing but am not sure if they are related
Uh oh!
There was an error while loading.Please reload this page.
Themodel and repo have been renamed. This PR adjusts the tag and snippets accordingly.