- Notifications
You must be signed in to change notification settings - Fork539
Update model-libraries.ts for depthanything-ac#1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@ghost233lism , thanks for your PR :) I've reviewed it and it's almost ready to merge. Can you make sure to addlibrary_name: depthanything-ac to your model card metadata inhttps://huggingface.co/ghost233lism/DepthAnything-AC/blob/main/README.md? This will make it appear athttps://huggingface.co/models?other=depthanything-ac for better discoverability.
| }, | ||
| "depthanything-ac":{ | ||
| prettyLabel:"DepthAnything-AC", | ||
| repoName:"DepthAnythingAC", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| repoName:"DepthAnythingAC", | |
| repoName:"DepthAnything-AC", |
let's keep same as "prettyLabel"
| prettyLabel:"DepthAnything-AC", | ||
| repoName:"DepthAnythingAC", | ||
| repoUrl:"https://github.com/HVision-NKU/DepthAnythingAC", | ||
| snippets:snippets.DepthAnythingAC, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| snippets: snippets.DepthAnythingAC, |
snippet doesn't seem to be defined for that library
pcuenca left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If the model is fine-tuned from DepthAnything V2, then is it really necessary to adddeptahanything-ac as a new library? If we assignlibrary_name: depth-anything-v2, likehere, would it just work out of the box? If so, I'd recommend doing that to reduce friction, and get usage snippets for free.
In addition, I'd recommend converting the model to transformers format and push it as a new repo. This way, it can be used directly from a transformers pipeline, which would also reduce friction and increase visibility. For example, the transformers version of depth-anything-v2 smallhad > 400K downloads in the last month, whereas downloads for the original librarywere ~10K.
No description provided.