Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

initial feature add#1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
gitPushPuppets wants to merge4 commits intohub4j:main
base:main
Choose a base branch
Loading
fromgitPushPuppets:feat/add-custom-properties

Conversation

@gitPushPuppets
Copy link

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility,CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add@link JavaDoc entries to the relevant documentation onhttps://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. SeeCONTRIBUTING.md for details.
  • Runmvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other thanmain. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation onhttps://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".


privatebooleancompareUsePaginatedCommits;

privateSet<GHRepositoryCustomProperty>custom_properties;
Copy link
Member

@bitwisemanbitwisemanDec 5, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thoughts: I'm not sure thatSet helps you here. You might want to represent this as

  • List - getting all of them
  • Map<String, String> - the docs seem to indicate that you can't have multiple properties with the samename value on a repository or organization. And the properties are just name/value pairs...
  • Map<String,CustomProperty> - This might be a good choice for future proofing, in case GitHub decides to make CustomProperty records more complex in future.

For either of theMap options you need to check whetherkey value uniqueness case-insensitive, case-sensitive but restricted to ASCII, or literary any Unicode/UTF-8 String.

I mean this as a discussion. I'm fully open to changing my mind.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I got my custom properties returned to me using this code base referenced in a console app.

I was discussing map options with a friend of mine but haven't been able to get it to work yet. I am not familiar with how this repo handles object mapping and kept running into null errors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We use Jackson.

Give an example of where you get null errors and we'll see if we can figure it out.

@bitwiseman
Copy link
Member

Looks reasonable. Only one comment so far.

@bitwisemanbitwiseman added the work-abandonedThere hasn't been any activity on the PR in a while. Another contributor might want to pick it up. labelSep 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bitwisemanbitwisemanbitwiseman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

work-abandonedThere hasn't been any activity on the PR in a while. Another contributor might want to pick it up.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gitPushPuppets@bitwiseman

[8]ページ先頭

©2009-2025 Movatter.jp