Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Code Scanning API support#1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
wwong wants to merge11 commits intohub4j:main
base:main
Choose a base branch
Loading
fromwwong:code-scanning-api
Draft

Conversation

@wwong
Copy link

@wwongwwong commentedFeb 7, 2024
edited
Loading

Description

Following up on open comments from#1142 andcortexapps#8

I don't currently have access to the security alerts for the example test repo (https://github.com/hub4j-test-org/Pixi), so the response fields might be slightly outdated until I (or someone else) can re-record the wiremock samples.

Start of an (incomplete) implementation for#1133 (will add more endpoints in a later PR)

This change adds the read-only calls for the following endpoints, as they were originally implemented in previous PRs:

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility,CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add@link JavaDoc entries to the relevant documentation onhttps://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. SeeCONTRIBUTING.md for details.
  • Runmvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other thanmain. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation onhttps://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@wwongwwong changed the titleCode scanning apiCode Scanning API supportFeb 7, 2024
@wwongwwongforce-pushed thecode-scanning-api branch 2 times, most recently fromf9767a5 to10d3458CompareFebruary 7, 2024 07:16
@wwong
Copy link
Author

Hi@bitwiseman, tagging you here because you're the only member of the hub4j org that I can see.

When you get the chance, could you approve the test workflows on this PR? The tests are passing locally, but I want to make sure things are all good in CI before I open up for review. It'd also be great to get access to the security alerts in the hub4j-test-org so that I can refresh the wiremock snapshots. Thanks!

@wwongwwongforce-pushed thecode-scanning-api branch 2 times, most recently fromc20ace1 to62361a5CompareFebruary 8, 2024 07:44
@bitwiseman
Copy link
Member

@wwong
I'm inviting you to the hub4j-test-org now.

@codecov
Copy link

codecovbot commentedFeb 15, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is78.94737% with24 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base(895ddce) to head(1e9c381).
Report is 1 commits behind head on main.

FilesPatch %Lines
...rg/kohsuke/github/GHCodeScanningAlertInstance.java52.27%9 Missing and 12 partials⚠️
...e/github/GHCodeScanningAlertInstancesIterable.java92.30%0 Missing and 1 partial⚠️
...g/kohsuke/github/GHCodeScanningAlertsIterable.java93.33%0 Missing and 1 partial⚠️
src/main/java/org/kohsuke/github/GHRepository.java88.88%1 Missing⚠️
Additional details and impacted files
@@             Coverage Diff              @@##               main    #1787      +/-   ##============================================- Coverage     81.05%   81.02%   -0.04%- Complexity     2442     2476      +34============================================  Files           237      242       +5       Lines          7342     7456     +114       Branches        398      412      +14     ============================================+ Hits           5951     6041      +90- Misses         1145     1155      +10- Partials        246      260      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@wwong
Copy link
Author

@bitwiseman Thanks! I'll see if I can find some time this weekend to shore up the code coverage and add some more support for the rest of the Code Scanning endpoints.

@bitwisemanbitwiseman added the work-abandonedThere hasn't been any activity on the PR in a while. Another contributor might want to pick it up. labelJul 1, 2024
bitwiseman
bitwiseman previously requested changesJul 1, 2024
Copy link
Member

@bitwisemanbitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Upstream changes to test data.

@bitwisemanbitwiseman self-requested a reviewJuly 1, 2024 18:33
@bitwisemanbitwiseman dismissed theirstale reviewJuly 1, 2024 18:33

Updates applied

@bitwiseman
Copy link
Member

@wwong
If/When you get back to this PR, please pull the changes I've applied and avoid force pushes to make reviewing easier.

@wwong
Copy link
Author

wwong commentedJul 1, 2024
edited
Loading

Will do, thanks@bitwiseman. Life is a little busy right now, but I hope to get back to this soon, maybe in the next couple weeks.

In the process of integrating these changes in a work project, I also found some areas for improvement in the proposed code scanning interfaces, which I'll also try to incorporate before finalizing the PR.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bitwisemanbitwisemanAwaiting requested review from bitwiseman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

work-abandonedThere hasn't been any activity on the PR in a while. Another contributor might want to pick it up.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wwong@bitwiseman@akashRindhe

[8]ページ先頭

©2009-2025 Movatter.jp