Commit8911496

committed

Fail on namespaces with BS.

1 parent47b430e commit8911496Copy full SHA for 8911496

File tree

+13

-6

lines changed

+13

-6

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,11 @@ def cloneNode(self):`
`134`	`134`	`raiseNotImplementedError`
`135`	`135`
`136`	`136`	`classTreeBuilder(_base.TreeBuilder):`
	`137`	`+def__init__(self,namespaceHTMLElements):`
	`138`	`+ifnamespaceHTMLElements:`
	`139`	`+warnings.warn("BeautifulSoup cannot represent elements in any namespace",DataLossWarning)`
	`140`	`+_base.TreeBuilder.__init__(self,namespaceHTMLElements)`
	`141`	`+`
`137`	`142`	`defdocumentClass(self):`
`138`	`143`	`self.soup=BeautifulSoup("")`
`139`	`144`	`returnElement(self.soup,self.soup,None)`
`@@ -152,8 +157,8 @@ def insertDoctype(self, token):`
`152`	`157`	`self.soup.insert(0,Declaration(name))`
`153`	`158`
`154`	`159`	`defelementClass(self,name,namespace):`
`155`		`-ifnamespacenotin (None,namespaces["html"]):`
`156`		`-warnings.warn("BeautifulSoup cannot representelemens innn-html namespace",DataLossWarning)`
	`160`	`+ifnamespaceisnotNone:`
	`161`	`+warnings.warn("BeautifulSoup cannot representelements inany namespace",DataLossWarning)`
`157`	`162`	`returnElement(Tag(self.soup,name),self.soup,namespace)`
`158`	`163`
`159`	`164`	`defcommentClass(self,data):`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,11 @@ def runParserTest(self, innerHTML, input, expected, errors, treeClass,`
`80`	`80`	`namespaceHTMLElements):`
`81`	`81`	`#XXX - move this out into the setup function`
`82`	`82`	`#concatenate all consecutive character tokens into a single token`
`83`		`-p=html5parser.HTMLParser(tree=treeClass,`
`84`		`-namespaceHTMLElements=namespaceHTMLElements)`
	`83`	`+try:`
	`84`	`+p=html5parser.HTMLParser(tree=treeClass,`
	`85`	`+namespaceHTMLElements=namespaceHTMLElements)`
	`86`	`+exceptconstants.DataLossWarning:`
	`87`	`+return`
`85`	`88`
`86`	`89`	`errors= [item.decode("utf-8")foriteminerrors]`
`87`	`90`
`@@ -92,7 +95,6 @@ def runParserTest(self, innerHTML, input, expected, errors, treeClass,`
`92`	`95`	`try:`
`93`	`96`	`document=p.parse(StringIO.StringIO(input))`
`94`	`97`	`exceptconstants.DataLossWarning:`
`95`		`-sys.stderr.write("Test input causes known dataloss, skipping")`
`96`	`98`	`return`
`97`	`99`	`except:`
`98`	`100`	`errorMsg="\n".join(["\n\nInput:",input,"\nExpected:",expected,`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -225,8 +225,8 @@ def sortattrs(x):`
`225`	`225`
`226`	`226`	`classTestCase(unittest.TestCase):`
`227`	`227`	`defrunTest(self,innerHTML,input,expected,errors,treeClass):`
`228`		`-p=html5parser.HTMLParser(tree=treeClass["builder"])`
`229`	`228`	`try:`
	`229`	`+p=html5parser.HTMLParser(tree=treeClass["builder"])`
`230`	`230`	`ifinnerHTML:`
`231`	`231`	`document=p.parseFragment(StringIO.StringIO(input),innerHTML)`
`232`	`232`	`else:`

Comments

(0)