Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow user to set hardware address instead of SSID when using macOS#3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bgoncal wants to merge13 commits intomaster
base:master
Choose a base branch
Loading
frommac-hardware-address

Conversation

@bgoncal
Copy link
Member

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncalbgoncal self-assigned thisNov 5, 2025
CopilotAI review requested due to automatic review settingsNovember 5, 2025 14:34
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances network configuration capabilities by adding support for hardware address (BSSID) input alongside network name (SSID) and makes the connection security level setting always visible in settings. It also adjusts modal presentation styles on macCatalyst to use fullScreenCover.

  • Added hardware address (BSSID) input field for macCatalyst platform
  • Made connection security level setting always visible (removed conditional hiding)
  • Changed modal presentation from sheet to fullScreenCover on macCatalyst for better UX

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
HomeNetworkInputView.swiftRefactored to support both network name and hardware address input with new context struct and conditional display for macCatalyst
OnboardingPermissionsNavigationViewModel.swiftUpdated to save both network name and hardware address from the new context
OnboardingPermissionsNavigationView.swiftUpdated callback to use new context-based approach
ConnectionSecurityLevelBlockView.swiftChanged modal presentation to fullScreenCover on macCatalyst and refactored settings view into a computed property
ConnectionSettingsViewController.swiftRemoved conditional hiding logic for connection security level setting

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

@bgoncalbgoncal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bgoncal
[8]ページ先頭
©2009-2025 Movatter.jp