- Notifications
You must be signed in to change notification settings - Fork180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
kcm: Deduplicate credentials when storing a new one#1261
Open
fihuer wants to merge1 commit intoheimdal:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Before, when storing a new credential, KCM will only append the new credential and never ever remove duplicates if it's not told to do so.This allows the credentials stored in a ccache to grow-up indefinitely in some situations.One of them if the usage of "krb5_cc_set_config" (used in gss_acquire_creds).krb5_cc_set_config is called multiple times when the credential is expired, until a valid credential is available.This leads to a huge number of duplicates credentials and, in the end, slows down KCM.With this commit, duplicate credential are removed and the newest is appended at the end.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, when storing a new credential, KCM will only append the new credential and never ever remove duplicates if it's not told to do so.
This allows the credentials stored in a ccache to grow-up indefinitely in some situations. One of them if the usage of "krb5_cc_set_config" (used in gss_acquire_creds). krb5_cc_set_config is called multiple times when the credential is expired, until a valid credential is available. This leads to a huge number of duplicates credentials and, in the end, slows down KCM.
With this commit, duplicate credential are removed and the newest is appended at the end.