- Notifications
You must be signed in to change notification settings - Fork662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: export package version#866
base:master
Are you sure you want to change the base?
Conversation
First, both libraries put some variant of this information in the Second, library users can already do |
Libraries use As for the second item, it won't be possible since the gax code can accept any |
If the current |
I don't think it's a good idea to export this information pre-formatted for a specific use-case. I would prefer to either export the whole |
I'm totally fine with either of those options - I just wanted to have the conversation started :) |
Since we are entering a phase when different client libraries will use different gRPC implementations (most will be migrated to
@grpc/grpc-js
but some will still stay withgrpc
), we'd like to have an easy way for the client library to set the gRPC version in the headers without actually knowing if thegrpc
instance they work with is a C-core or JS implementation.Can we have this
grpc.version
added to both implementations to make this tracking easier? (or feel free to suggest another options!)