NotificationsYou must be signed in to change notification settings
Fork353
Star5.3k

Handle negative index in vertex processing#5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

kainino0x wants to merge1 commit intogpuweb:main

base:main

Choose a base branch

fromkainino0x:handle-negative-index

Open

Handle negative index in vertex processing#5076

kainino0x wants to merge1 commit intogpuweb:mainfromkainino0x:handle-negative-index

Conversation

Copy link

Contributor

kainino0x commentedFeb 19, 2025

Also refactor the prose slightly so that this change makes more sense in context.

Fixes#5064

Handle negative index in vertex processing

f6c145d

Also refactor the prose slightly so that this change makes more sense incontext.Fixes 5064

kainino0x added copyediting

Pure editorial stuff (copyediting, *.bs file syntax, etc.)

apiWebGPU API labels

Feb 19, 2025

kainino0x added this to theMilestone 1 milestone

Feb 19, 2025

kainino0x requested a review fromtoji

February 19, 2025 19:59

Copy link

Contributor

github-actionsbot commentedFeb 19, 2025

Previews, as seen when thisbuild job started (f6c145d):
WebGPU_{webgpu.idl |Explainer |Correspondence Reference}
WGSL_{grammar.js |wgsl.lalr.txt}

kainino0x requested a review fromjimblandy

February 19, 2025 21:17

Copy link

ContributorAuthor

kainino0x commentedFeb 19, 2025

Oh, Brandon is out. Jim, could you review?

kainino0x requested a review frommwyrzykowski

February 20, 2025 16:56

mwyrzykowski reviewed

Feb 20, 2025

View reviewed changes

Copy link

mwyrzykowski left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Doesn't the definition ofvertexElementRelativeOffset still allow for negativevertexElementIndex? E.g., consider

|vertexElementIndex| * |vertexBufferLayout|.{{GPUVertexBufferLayout/arrayStride}} +                |attributeDesc|.{{GPUVertexAttribute/offset}}.

as long as|attributeDesc|.{{GPUVertexAttribute/offset}} >=-|vertexElementIndex| * |vertexBufferLayout|.{{GPUVertexBufferLayout/arrayStride}} then as written I believevertexElementIndex < 0 would still be allowed.

Is negativevertexElementIndex supported across all APIs? I could only find reference in the GL specification which says it is not. Specifically I would wonder which values are populated invertex_index on the shader side.