Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork908
fix: restore bottom sheet when keyboard is dismissed#2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
michael-pingo-ai wants to merge1 commit intogorhom:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| position!==closedDetentPosition | ||
| ){ | ||
| index=highestDetentPosition??DEFAULT_KEYBOARD_INDEX; | ||
| index=detents?.indexOf(highestDetentPosition??0)??DEFAULT_KEYBOARD_INDEX; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just found the same bug and was about to open the same pr😁
I think it is better to just get the last item of the array since we know they are sorted in ascending order, right?
Suggested change
| index=detents?.indexOf(highestDetentPosition??0)??DEFAULT_KEYBOARD_INDEX; | |
| index=detents?.length ?detents.length-1 :DEFAULT_KEYBOARD_INDEX; |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Please provide enough information so that others can review your pull request:
Motivation
Explain themotivation for making this change. What existing problem does the pull request solve?
This PR fixes a bug where the bottom sheet could assign a raw position value to index when the keyboard was shown. This caused animatedCurrentIndex to be set to invalid values (e.g.
235), which led to broken state and the sheet height not resetting when the keyboard was dismissed.The fix ensures index is resolved against the detents array, falling back to DEFAULT_KEYBOARD_INDEX if no match is found.
Solves:
#2509
#2465
#2460