Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork908
fix: getBoundingClientRect undefined check#2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
pinpong wants to merge4 commits intogorhom:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mgcrea commentedOct 9, 2025
This is now crashing in Proper fix imo: diff --git a/src/hooks/useBoundingClientRect.ts b/src/hooks/useBoundingClientRect.tsindex cc85c8ced2de8ec514360368ed20af733f8f9aec..cb92a016d67215a65a1d2b9ce710d6be34a36a6b 100644--- a/src/hooks/useBoundingClientRect.ts+++ b/src/hooks/useBoundingClientRect.ts@@ -56,7 +56,7 @@ export function useBoundingClientRect( } // @ts-ignore 👉 https://github.com/facebook/react/commit/53b1f69ba- if (ref.current.unstable_getBoundingClientRect !== null) {+ if (typeof ref.current.unstable_getBoundingClientRect === "function") { // @ts-ignore https://github.com/facebook/react/commit/53b1f69ba const layout = ref.current.unstable_getBoundingClientRect(); handler(layout);@@ -64,7 +64,7 @@ export function useBoundingClientRect( } // @ts-ignore once it `unstable_getBoundingClientRect` gets stable 🤞.- if (ref.current.getBoundingClientRect !== null) {+ if (typeof ref.current.getBoundingClientRect === "function") { // @ts-ignore once it `unstable_getBoundingClientRect` gets stable. const layout = ref.current.getBoundingClientRect(); handler(layout); |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#2494 because
!== nullnot checking if undefinedI have the same error after updating to RN0.82.0-rc4