- Notifications
You must be signed in to change notification settings - Fork351
Skip expired backfills instead of returning error#1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
glindstedt wants to merge1 commit intogoogleforgames:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| }) | ||
| // Depends on pendingReleaseTimeout | ||
| time.Sleep(1*time.Second) |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a bit ugly, would be nice if we could have something likek8s.io/utils/clock/testing to pass the time
7924516 tof31067dCompareIf a single backfill has expired it would cause the whole FetchMatchescall to error out. Now the backfill will be skipped instead similar tothe NotFound case. The status code returned for attempting toacknowledge or update an expired backfill is changed from Unavailablesince the operation is not retryable.
f31067d to7fc3eb3Compare| iferr!=nil { | ||
| e,ok:=status.FromError(err) | ||
| iferr==errBackfillGenerationMismatch|| (ok&&e.Code()==codes.NotFound) { | ||
| iferr==errBackfillGenerationMismatch|| (ok&&(e.Code()==codes.NotFound||e.Code()==codes.FailedPrecondition)) { |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is the main change
lonefreak approved these changesNov 13, 2023
govargo added a commit to govargo/open-match that referenced this pull requestJun 24, 2024
govargo added a commit to govargo/open-match that referenced this pull requestJul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
If a single backfill has expired it would cause the whole FetchMatches call to error out. Now instead the backfill will be skipped, similar to the
NotFoundcase.The status code returned for attempting to acknowledge or update an expired backfill is changed from Unavailable since the operation is not retryable. I opted for
FailedPrecondition, but maybeInvalidArgumentcould make more sense since you can't "revive" the backfill, only create a new one if it expired.Special notes for your reviewer:
There are some formatting changes from format-on-save, let me know if I should remove them to make the PR clearer.