Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add support for Vertex AI#127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Vibgitcode27 wants to merge2 commits intogoogle-gemini:main
base:main
Choose a base branch
Loading
fromVibgitcode27:feat/add_vertex_ai_support

Conversation

@Vibgitcode27
Copy link

Fixes :#84 and#110

This adds support for Vertex AI authentication alongside the existing API key method.

@gemini-code-assist
Copy link

Summary of Changes

Hello@Vibgitcode27, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's authentication capabilities by integrating support for Google's Vertex AI. This change provides a more robust and flexible way to connect to AI services, particularly benefiting users who require Workload Identity Federation (WIF) for secure access. The update allows for easy switching between API key and Vertex AI authentication methods through simple environment variable configurations, ensuring adaptability for various deployment scenarios.

Highlights

  • Vertex AI Integration: Added comprehensive support for authenticating with Vertex AI, allowing the application to leverage Google Cloud's managed machine learning platform.
  • Flexible Authentication Mechanism: Implemented a dynamic authentication selection process, enabling users to switch between Vertex AI and the existing API key method via environment variables.
  • Configuration Updates: Introduced new environment variables (REACT_APP_USE_VERTEX_AI,REACT_APP_GOOGLE_CLOUD_PROJECT,REACT_APP_GOOGLE_CLOUD_LOCATION) to configure Vertex AI settings.
  • Type Definition Refinement: Updated theLiveClientOptions type insrc/types.ts to remove the explicitapiKey requirement, accommodating the new Vertex AI authentication flow which does not directly use an API key.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

Copy link

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request adds support for Vertex AI authentication as an alternative to the existing API key method. The changes are generally good, introducing a factory function to handle the different authentication configurations. However, I've found a logical error in how the Vertex AI mode is enabled, which would cause the opposite of the intended behavior. I've also included some suggestions to improve code safety and consistency regarding environment variable handling and to update a related code comment that has become outdated.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Support For Using With GCP

1 participant

@Vibgitcode27
[8]ページ先頭
©2009-2025 Movatter.jp