Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Report packages loading failure with a specific exit-code#4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
podtserkovskiy wants to merge1 commit intogolangci:master
base:master
Choose a base branch
Loading
frompodtserkovskiy:report_packages_loading_failure

Conversation

@podtserkovskiy
Copy link

Thepackages.Load() function can use anexternal package providerGOPACKAGESDRIVER for third-party build-systems like Bazel or Buck2.

Having a specific exit code when external driver fails would increase observability and will help to distinguishGOPACKAGESDRIVER's failures from other kinds of failures.

@boring-cyborg
Copy link

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commentedAug 28, 2024•
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

@ldezldez self-requested a reviewAugust 28, 2024 11:30
@ldezldez added area: CLIRelated to CLI blockedNeed's direct action from maintainer labelsAug 28, 2024
@podtserkovskiy
Copy link
Author

@ldez Is there something I can do to get this PR merged?

ldez reacted with eyes emoji

@ldez
Copy link
Member

I'm unsure to understand how this "increases observability and will help to distinguishGOPACKAGESDRIVER's failures from other kinds of failures".
The error message is already "unique" 🤔

Can you provide more details?

@ldezldez added waiting for: contributor feedbackRequires additional feedback and removed blockedNeed's direct action from maintainer labelsJan 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ldezldezAwaiting requested review from ldez

Assignees

No one assigned

Labels

area: CLIRelated to CLIwaiting for: contributor feedbackRequires additional feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@podtserkovskiy@CLAassistant@ldez
[8]ページ先頭
©2009-2025 Movatter.jp