Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
Addgofactory linter#4196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
maranqz wants to merge19 commits intogolangci:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+142 −2
Open
Addgofactory linter#4196
Changes from1 commit
Commits
Show all changes
19 commits Select commitHold shift + click to select a range
bbe0eb9 1. Added reference
maranqz70cd3e5 1. Update version after type fixes
maranqz5a86fb8 1. Added tests in subdir
maranqz2a31b53 1. Bump golangci-lint version
maranqz22e29b7 1. Fixed settings name
maranqzfaecc6b 1. Fixed test with config file
maranqz2fde9ce 1. Update config after linter fixing
maranqzbb4065b 1. Remove slog to pass go1.20 test
maranqz419bf43 Merge branch 'master' into go-factory-lint
maranqze40eddf Merge branch 'master' into go-factory-lint
maranqz930e2b2 1. Added casting function
maranqzc1195cf 1. renamed linter
maranqzba1ed19 Merge branch 'master' into go-factory-lint
maranqz2b59b9d 1. fixed tests
maranqzeb43dd5 1. moved gofactory test from dedicated to common directory
maranqzdf588bc Merge branch 'master' into go-factory-lint
maranqza1dbfe1 Merge branch 'master' into go-factory-lint
maranqz985e045 Merge branch 'master' into go-factory-lint
maranqz111f638 Merge branch 'master' into go-factory-lint
maranqzFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
1. Remove slog to pass go1.20 test
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitbb4065b512c146ec8879ec611a4b9bcba3c9847b
There are no files selected for viewing
2 changes: 1 addition & 1 deletiongo.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -69,7 +69,7 @@ require ( | ||
| github.com/leonklingele/grouper v1.1.1 | ||
| github.com/lufeee/execinquery v1.2.1 | ||
| github.com/macabu/inamedparam v0.1.2 | ||
| github.com/maranqz/go-factory-lint/v2 v2.0.0-beta.4 | ||
maranqz marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| github.com/maratori/testableexamples v1.0.0 | ||
| github.com/maratori/testpackage v1.1.1 | ||
| github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26 | ||
4 changes: 2 additions & 2 deletionsgo.sum
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.