Nov 12, 2023 · Nov 15, 2023 · Nov 15, 2023 · Nov 15, 2023 · Nov 15, 2023 · Nov 15, 2023
diff --git a/test/run_test.go b/test/run_test.go
 "--timeout=3m",
 "--enable-all",
 "-D",
 "nosnakecase,gci",
 "nosnakecase,gci,gofactory",
 ).
 WithTargetPath(testdataDir, "cgo").
 Runner().
 func TestUnsafeOk(t *testing.T) {
 testshared.NewRunnerBuilder(t).
 WithNoConfig().
 WithArgs("--enable-all").
 WithArgs(
 "--enable-all",
 "-D",
 "gofactory",
 ).
 WithTargetPath(testdataDir, "unsafe").
 Runner().
 Install().
Original file line number	Diff line number	Diff line change
Expand Up		@@ -137,7 +137,7 @@ func TestCgoOk(t *testing.T) {
		"--timeout=3m",
		"--enable-all",
		"-D",
		"nosnakecase,gci",
		"nosnakecase,gci,gofactory",
Copy link Author maranqzDec 15, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I hope that is correct solution to pass tests. Copy link Member ldezDec 15, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. your tests are not in the right places. Copy link Author maranqzDec 15, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Do you mean I should move`test/testdata/gofactory/blocked.go` to`test/testdata/gofactory/gofactory_package_globs_only.go`? Copy link Member ldezDec 15, 2023• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. no, your tests must be inside`test/testdata/` and not a dedicated folder. and your linter should be removed from`test/linters_test.go`. #4196 (comment) Copy link Contributor AntonboomJan 7, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. need to rollback Copy link Author maranqzJan 7, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I added because of linter error`Use factory for unsafe.Pointer`. Should I add option to exclude checking of std libraries in gofactory? Copy link Contributor AntonboomJan 8, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should I add option to exclude checking of std libraries in gofactory? Nice idea, but I think in case of`exclude-std=false` we will receive false positive anyway, because a lot of std types could be (or must be) used without factory by design. Like`unsafe.Pointer` or`sync.Mutex`. Zero value is useful 🙂 Look at `$ cd $GOROOT/src$ gofactory -json ./... \| jq '.[] \| .[] \| .[] .message' \| sort \| uniq`
		).
		WithTargetPath(testdataDir, "cgo").
		Runner().
Expand DownExpand Up		@@ -355,7 +355,11 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
		func TestUnsafeOk(t *testing.T) {
		testshared.NewRunnerBuilder(t).
		WithNoConfig().
		WithArgs("--enable-all").
Copy link Contributor AntonboomJan 7, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. how does this change relate to PR? Copy link Author maranqzJan 7, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. If I return, can I add`-D gofactory` to fix linter error`Use factory for unsafe.Pointer`. Or is solution from comment is better? #4196 (comment) Copy link Member ldezJan 7, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. this should be reverted.
		WithArgs(
		"--enable-all",
		"-D",
		"gofactory",
		).
		WithTargetPath(testdataDir, "unsafe").
		Runner().
		Install().
Expand Down