Movatterモバイル変換

Skip to content

golangci/golangci-lintPublic

NotificationsYou must be signed in to change notification settings
Fork1.5k
Star17.9k

fix: run os.exit on persistent post run only when executor has non-zero exitcode#4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

kraashen wants to merge1 commit intogolangci:master

base:master

Choose a base branch

fromkraashen:bugfix/persistent-post-run-early-exit

Open

fix: run os.exit on persistent post run only when executor has non-zero exitcode#4138

kraashen wants to merge1 commit intogolangci:masterfromkraashen:bugfix/persistent-post-run-early-exit

Conversation

@kraashen

Copy link

kraashen commentedOct 18, 2023•
edited
Loading

As described in issue#4137 and linked reproduction sample, when running golangci-lint in a Magefile target in a serial flow with other targets withSerialCtxDeps, the serially executed target pipeline is exited prematurely due toos.exit.

Not sure if this PR is applicable for the context in thePersistentPostRunE handler that is passed to Cobra, but this PR attempts to by implementing a check where:

os.Exit is run only when exit code of the executor was non-zero
returnnil otherwise

Fixes#4137

@boring-cyborg

Copy link

boring-cyborgbot commentedOct 18, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant

Copy link

CLAassistant commentedOct 18, 2023•
edited
Loading

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}

@ldez

ldez self-requested a review

October 18, 2023 13:22

@ldez

ldez added area: CLI

Related to CLI

blockedNeed's direct action from maintainer labels

@kraashen

kraashen force-pushed thebugfix/persistent-post-run-early-exit branch from34382d0 to23c16faCompare

October 19, 2023 16:41

@kraashen

exit persistent post run when executor has non-zero exitcode

e861ab3

@kraashen

kraashen force-pushed thebugfix/persistent-post-run-early-exit branch from23c16fa toe861ab3Compare

October 23, 2023 13:03

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Related to CLI

Need's direct action from maintainer

3 participants

@kraashen

@CLAassistant

@ldez

[8]ページ先頭

©2009-2025 Movatter.jp