Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
feat: add untypedconst linter#3527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
leonklingele wants to merge1 commit intogolangci:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+112 −0
Open
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions.golangci.next.reference.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletionsgo.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletionsgo.sum
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
67 changes: 67 additions & 0 deletionspkg/golinters/untypedconst/testdata/untypedconst.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| //golangcitest:args -Euntypedconst | ||
| package testdata | ||
| import ( | ||
| "fmt" | ||
| ) | ||
| type ExString string | ||
| func retExString() ExString { | ||
| if true { | ||
| return ExString("hoge") | ||
| } else { | ||
| fmt.Println("This should never happen") | ||
| return "hoge" // want `returning untyped constant as defined type "command-line-arguments.ExString"` | ||
| } | ||
| } | ||
| type ExInt int | ||
| func retExInt() ExInt { | ||
| if true { | ||
| return ExInt(1) | ||
| } else { | ||
| return 1 // want `returning untyped constant as defined type "command-line-arguments.ExInt"` | ||
| } | ||
| } | ||
| type ExFloat float64 | ||
| func retExFloat() ExFloat { | ||
| if true { | ||
| return ExFloat(0.5) | ||
| } else { | ||
| return 0.5 // want `returning untyped constant as defined type "command-line-arguments.ExFloat"` | ||
| } | ||
| } | ||
| type ExComplex complex128 | ||
| func retExComplex() ExComplex { | ||
| if true { | ||
| return ExComplex(1.0 + 0.5i) | ||
| } else { | ||
| return 1.0 + 0.5i // want `returning untyped constant as defined type "command-line-arguments.ExComplex"` | ||
| } | ||
| } | ||
| type ExRune rune | ||
| func retExRune() ExRune { | ||
| if true { | ||
| return ExRune('a') | ||
| } else { | ||
| return 'a' // want `returning untyped constant as defined type "command-line-arguments.ExRune"` | ||
| } | ||
| } | ||
| type ExBool bool | ||
| func retExBool() ExBool { | ||
| if true { | ||
| return ExBool(true) | ||
| } else { | ||
| return true // want `returning untyped constant as defined type "command-line-arguments.ExBool"` | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletionspkg/golinters/untypedconst/untypedconst.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package untypedconst | ||
| import ( | ||
| "github.com/jiftechnify/untypedconst" | ||
| "golang.org/x/tools/go/analysis" | ||
| "github.com/golangci/golangci-lint/pkg/goanalysis" | ||
| ) | ||
| func New() *goanalysis.Linter { | ||
| a := untypedconst.Analyzer | ||
| return goanalysis.NewLinter( | ||
| a.Name, | ||
| a.Doc, | ||
| []*analysis.Analyzer{a}, | ||
| nil, | ||
| ).WithLoadMode(goanalysis.LoadModeTypesInfo) | ||
| } |
7 changes: 7 additions & 0 deletionspkg/lint/lintersdb/builder_linter.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.