Jan 7, 2023 · Jan 7, 2023 · Jan 8, 2023 · Jan 8, 2024 · Feb 2, 2023
diff --git a/go.mod b/go.mod
 gopkg.in/yaml.v2 v2.4.0 // indirect
 mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
 )

 require github.com/atzoum/reuseconn v0.1.0 // indirect
diff --git a/go.sum b/go.sum
diff --git a/pkg/golinters/reuseconn.go b/pkg/golinters/reuseconn.go
 package golinters

 import (
 "github.com/atzoum/reuseconn/reuseconn"
 "golang.org/x/tools/go/analysis"

 "github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
 )

 func NewReuseconn() *goanalysis.Linter {
 return goanalysis.NewLinter(
 "reuseconn",
 "checks whether HTTP response body is consumed and closed properly in a single function",
 []*analysis.Analyzer{reuseconn.Analyzer},
 nil,
 ).WithLoadMode(goanalysis.LoadModeWholeProgram)
 }
diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
 ConsiderSlow().
 WithURL("https://github.com/mgechev/revive"),

 linter.NewConfig(golinters.NewReuseconn()).
 WithSince("v1.51.0").
 WithLoadForGoAnalysis().
 WithPresets(linter.PresetPerformance, linter.PresetBugs).
 WithURL("https://github.com/atzoum/reuseconn"),

 linter.NewConfig(golinters.NewRowsErrCheck(rowserrcheckCfg)).
 WithSince("v1.23.0").
 WithLoadForGoAnalysis().
diff --git a/test/testdata/reuseconn.go b/test/testdata/reuseconn.go
 //golangcitest:args -Ereuseconn
 package testdata

 import (
 "io"
 "io/ioutil"
 "net/http"
 )

 funcBodyNotDisposedInSingleFunction() {
 resp,_:=http.Get("https://google.com")// want "response body must be disposed properly in a single function read to completion and closed"
 _,_=ioutil.ReadAll(resp.Body)
 resp.Body.Close()
 }

 funcBodyDisposedInSingleFunction() {
 resp,_:=http.Get("https://google.com")
 disposeResponse(resp)
 }

 funcdisposeResponse(resp*http.Response) {
 ifresp!=nil&&resp.Body!=nil {
 _,_=io.Copy(io.Discard,resp.Body)
 _=resp.Body.Close()
 }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -187,3 +187,5 @@ require (
		gopkg.in/yaml.v2 v2.4.0 // indirect
		mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
		)

		require github.com/atzoum/reuseconn v0.1.0 // indirect
Copy link Contributor chrishalbertJan 8, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should this be moved up into the existing block of indirect required modules?
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,17 @@
		package golinters

		import (
		"github.com/atzoum/reuseconn/reuseconn"
		"golang.org/x/tools/go/analysis"

		"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
		)

		func NewReuseconn() *goanalysis.Linter {
		return goanalysis.NewLinter(
		"reuseconn",
		"checks whether HTTP response body is consumed and closed properly in a single function",
		[]*analysis.Analyzer{reuseconn.Analyzer},
		nil,
		).WithLoadMode(goanalysis.LoadModeWholeProgram)
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -715,6 +715,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
		ConsiderSlow().
		WithURL("https://github.com/mgechev/revive"),

		linter.NewConfig(golinters.NewReuseconn()).
		WithSince("v1.51.0").
		WithLoadForGoAnalysis().
		WithPresets(linter.PresetPerformance, linter.PresetBugs).
		WithURL("https://github.com/atzoum/reuseconn"),

		linter.NewConfig(golinters.NewRowsErrCheck(rowserrcheckCfg)).
		WithSince("v1.23.0").
		WithLoadForGoAnalysis().
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,26 @@
		//golangcitest:args -Ereuseconn
		package testdata

		import (
		"io"
		"io/ioutil"
Copy link Member alexandearFeb 2, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Please use`io` instead of deprecated`ioutil`. sashamelentyev reacted with thumbs up emoji
		"net/http"
		)

		funcBodyNotDisposedInSingleFunction() {
		resp,_:=http.Get("https://google.com")// want "response body must be disposed properly in a single function read to completion and closed"
		_,_=ioutil.ReadAll(resp.Body)
		resp.Body.Close()
		}

		funcBodyDisposedInSingleFunction() {
		resp,_:=http.Get("https://google.com")
		disposeResponse(resp)
		}

		funcdisposeResponse(resp*http.Response) {
		ifresp!=nil&&resp.Body!=nil {
		_,_=io.Copy(io.Discard,resp.Body)
		_=resp.Body.Close()
		}
		}