- Notifications
You must be signed in to change notification settings - Fork18.6k
runtime: optimize zeroing of registers in secret_amd64.s#76830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
Use VPXORQ instead of VMOVAPD because the former, when in the form of a zeroing idiom, is handled directly by the renamer.Tweak also the KXORQs to operate each on a single register, making it trivial to understand what the intent is, and so that all can potentially execute in parallel.
gopherbot commentedDec 14, 2025
This PR (HEAD:2e02768) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/729940. Important tips:
|
gopherbot commentedDec 14, 2025
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 14, 2025
Message from Jorropo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 15, 2025
Message from Carlo Alberto Ferraris: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 15, 2025
Message from Carlo Alberto Ferraris: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 15, 2025
Message from Daniel Morsing: Patch Set 2: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 15, 2025
Message from Jorropo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 15, 2025
Message from Keith Randall: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 15, 2025
Message from Martin Möhrmann: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 16, 2025
Message from Carlo Alberto Ferraris: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
gopherbot commentedDec 16, 2025
Message from Carlo Alberto Ferraris: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/729940. |
Uh oh!
There was an error while loading.Please reload this page.
Use VPXORQ instead of VMOVAPD because the former, when in the form of a zeroing idiom, is handled directly by the renamer.
Tweak also the KXORQs to operate each on a single register, making it trivial to understand what the intent is, and so that all can potentially execute in parallel.