NotificationsYou must be signed in to change notification settings
Fork18.7k
Star131k

runtime: replace compare with max/min for improve the readable#76730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

jianfengtony wants to merge1 commit intogolang:master

base:master

Choose a base branch

fromjianfengtony:refactor_pacer

Open

runtime: replace compare with max/min for improve the readable#76730

jianfengtony wants to merge1 commit intogolang:masterfromjianfengtony:refactor_pacer

+62 −73

Conversation

Copy link

jianfengtony commentedDec 6, 2025

this PR refactor the gcpacer:

change some range compare condition to make it more readable
change some compare to builtin max/min to make it more readable

runtime: replace compare with max/min for improve the readable

dd547e3

Copy link

Contributor

gopherbot commentedDec 6, 2025

This PR (HEAD:dd547e3) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/727640.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account tolog in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click theblueReply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

Copy link

Contributor

gopherbot commentedDec 6, 2025

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727640.
After addressing review feedback, remember topublish your drafts!

Copy link

Contributor

gopherbot commentedDec 6, 2025

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. Seehttps://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727640.
After addressing review feedback, remember topublish your drafts!