Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/goPublic

net: fix some ineffectual assignments reported by ineffassign#76704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
linsite wants to merge1 commit intogolang:master
base:master
Choose a base branch
Loading
fromlinsite:fix-ineffectual-assignment

Conversation

@linsite
Copy link
Contributor

@linsitelinsite commentedDec 5, 2025•
edited
Loading

Updates#35136

@gopherbot
Copy link
Contributor

This PR (HEAD:b62df43) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/727080.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Lin Lin:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: Code-Review+2 Commit-Queue+1

(5 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T06:54:13Z","revision":"19f8657aca936cd2e3921c3151c0436fdf72df5b"}

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjobgolang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

To reproduce, trygomote repro 8696343417028376241.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@linsitelinsiteforce-pushed thefix-ineffectual-assignment branch fromb62df43 todc13df6CompareDecember 5, 2025 08:55
@gopherbot
Copy link
Contributor

This PR (HEAD:dc13df6) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/727080.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 2: Code-Review+2 Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T09:03:27Z","revision":"6c673cfb766c28bdfcb9d987478077a230df186b"}

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjobgolang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

To reproduce, trygomote repro 8696335285524338097.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Lin Lin:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T09:18:51Z","revision":"6c673cfb766c28bdfcb9d987478077a230df186b"}

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjobgolang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

To reproduce, trygomote repro 8696334317640969233.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T09:37:21Z","revision":"6c673cfb766c28bdfcb9d987478077a230df186b"}

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjobgolang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

To reproduce, trygomote repro 8696333152779955265.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Florian Lehner:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@linsitelinsiteforce-pushed thefix-ineffectual-assignment branch fromdc13df6 to6db1a88CompareDecember 6, 2025 00:43
@gopherbot
Copy link
Contributor

This PR (HEAD:6db1a88) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/727080.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Lin Lin:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 4: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-06T01:31:55Z","revision":"a701730c5f5bd4da89660fd4d511dc1a4d3ebdee"}

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 5: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-06T04:59:44Z","revision":"132da81bc5011307e45f40e14513c6f87bd91aff"}

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visitgolang.org/cl/727080.
After addressing review feedback, remember topublish your drafts!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@atul-007atul-007atul-007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linsite@gopherbot@atul-007
[8]ページ先頭
©2009-2025 Movatter.jp