- Notifications
You must be signed in to change notification settings - Fork18.6k
Fix removeEmptyPort#76652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Fix removeEmptyPort#76652
Conversation
remove hasPort and simplify logic
gopherbot commentedDec 2, 2025
This PR (HEAD:770502a) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/725605. Important tips:
|
gopherbot commentedDec 2, 2025
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605. |
gopherbot commentedDec 2, 2025
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605. |
gopherbot commentedDec 2, 2025
This PR (HEAD:2eb154b) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/725605. Important tips:
|
gopherbot commentedDec 2, 2025
Message from sz dxasu: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605. |
gopherbot commentedDec 2, 2025
Message from Damien Neil: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605. |
gopherbot commentedDec 2, 2025
Message from Damien Neil: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605. |
gopherbot commentedDec 3, 2025
This PR (HEAD:647cf55) has been imported to Gerrit for code review. Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/725605. Important tips:
|
gopherbot commentedDec 3, 2025
Message from sz dxasu: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605. |
Uh oh!
There was an error while loading.Please reload this page.
remove hasPort and simplify logic
Fixes#76651