Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/goPublic

Fix removeEmptyPort#76652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dxasu wants to merge3 commits intogolang:master
base:master
Choose a base branch
Loading
fromdxasu:patch-1
Open

Fix removeEmptyPort#76652

dxasu wants to merge3 commits intogolang:masterfromdxasu:patch-1

Conversation

@dxasu
Copy link
Contributor

@dxasudxasu commentedDec 2, 2025
edited
Loading

remove hasPort and simplify logic

Fixes#76651

remove hasPort and simplify logic
@gopherbot
Copy link
Contributor

This PR (HEAD:770502a) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/725605.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD:2eb154b) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/725605.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from sz dxasu:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 2:

(3 comments)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605.
After addressing review feedback, remember topublish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD:647cf55) has been imported to Gerrit for code review.

Please visit Gerrit athttps://go-review.googlesource.com/c/go/+/725605.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account tolog in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking asDone in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click theblueReply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See theSending a change via GitHub andReviews sections of the Contribution Guide as well as theFAQ for details.

@gopherbot
Copy link
Contributor

Message from sz dxasu:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visitgolang.org/cl/725605.
After addressing review feedback, remember topublish your drafts!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

net/http:remoteEmptyPort could be optimized

2 participants

@dxasu@gopherbot

[8]ページ先頭

©2009-2025 Movatter.jp