Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork23.8k
[DRAFT] Disable subpasses on Samsung Galaxy XR to avoid issue with MSAA and eye-tracked foveated rendering#114061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
dsnopek wants to merge2 commits intogodotengine:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+45 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ye-tracked foveated rendering
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#113778
I'm not sure this is a good idea. Theoretically, using subpasses is important for mobile rendering so disabling them on Samsung Galaxy XR may be bad for performance (although, according to Clay, it might not be in practice, depending on the circumstances).
It's also not ideal that this'll disable them always, rather than just in the combination of features that show the problem (that being MSAA + eye-tracked foveated rendering), however, in any serious app for this headset you would almost certainly have both those features enabled.
I'm also not sure if only this particular driver version is affected, but we have to target the driver version, because this problem does NOT occur on Meta Quest 3 (which has the same device ID), even if I force the Vulkan FDM offset extension to be enabled and give a fake offset. (Note: this wouldn't normally happen on the Quest 3 because it doesn't support eye-tracked foveated rendering, only fixed foveated rendering.)
So, marking as a DRAFT because:
avoid_subpass_post_processworkaround flag. #113823