Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use AWS S3 SDK instead of Minio Client SDK#36118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
junoberryferry wants to merge4 commits intogo-gitea:main
base:main
Choose a base branch
Loading
fromjunoberryferry:mino-to-aws-sdk

Conversation

@junoberryferry
Copy link
Contributor

No description provided.

lunny and chrisdsa reacted with thumbs up emoji
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelDec 9, 2025
@github-actionsgithub-actionsbot added modifies/goPull requests that update Go code modifies/dependencies labelsDec 9, 2025
@lunnylunny added this to the1.26.0 milestoneDec 9, 2025
@lunnylunny changed the titleUse AWS S3 SDK instead of MinioUse AWS S3 SDK instead of Minio Client SDKDec 9, 2025
@silverwind
Copy link
Member

silverwind commentedDec 11, 2025•
edited
Loading

I think we should renamemodules/storage/minio.* tomodules/storage/s3.*. The PR diff for these two files should remain readable after such a rename.

lunny and lafriks reacted with thumbs up emoji

@silverwind
Copy link
Member

silverwind commentedDec 12, 2025•
edited
Loading

Seems like I was wrong and GitHub's (or git's) move heuristic has split the diff ofmodules/storage/s3.go into two files. The proper diff can still be reviewed at this link:

https://github.com/go-gitea/gitea/pull/36118/changes/BASE..7064923a7d27181e0a22df8cb3073bbeee4eaf57

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsDec 16, 2025
Copy link
Contributor

@wxiaoguangwxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry but there are still concerns needing to address.

  1. data, err := io.ReadAll(r) will cause OOM when uploading files with GB sizes
    • It will make the instance crash and lead to DoS attack
  2. Changed logic, need to review carefully (I haven't really looked into details)

And another question is: whether it's worth to use AWS SDK to replace MinIO SDK?

  • Server side:
    • AWS: closed source
    • MinIO: still open-source (althought only the core code)
  • SDK side:
    • AWS: Apache-2, actively maintained
    • MinIO: Apache-2, actively maintained

So I don't see necessity at the moment.

Feel free to dismiss the change request if these concerns get addressed.

Comment on lines 532 to 533
// Buffer the content - required for proper Content-Length handling
data, err := io.ReadAll(r)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It will cause OOM if the uploaded file is large.

@GiteaBotGiteaBot added lgtm/blockedA maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsDec 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wxiaoguangwxiaoguangwxiaoguang requested changes

@silverwindsilverwindsilverwind approved these changes

Assignees

No one assigned

Labels

lgtm/blockedA maintainer has reservations with the PR and thus it cannot be mergedmodifies/dependenciesmodifies/goPull requests that update Go code

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@junoberryferry@silverwind@wxiaoguang@lunny@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp