Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Implement .org file rendering in Wiki#36018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Instead of hard coding it to be markdown only and allow for org files tobe detected and rendered properly
Resort to raw file if neither is found too.
Used Git filename to properly handle .org files
This handles .org files markup detection
markdown files still take priority over org files if both are present
Modernise string suffix check with CutSuffixAdded nilcheck for entry after the org version check attempt
lunny commentedNov 24, 2025
I think we should introduce a configuration option for the Wiki to choose between markdown and org. This way, we won’t need to handle both formats everywhere, which is not sustainable in the long term. Additionally, we should add tests to ensure that the new file type works correctly. |
LinlyBoi commentedNov 25, 2025
Would the configuration be per-repo or instance wide? I think even an option to include both formats is viable since both formats can coexist without issue. I will try to add that but any pointers would be great! |
lunny commentedNov 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Per-repository, the configuration name should be |
- listing of wiki pages now depends on option and defaults to markdownonly
Updated all calls of function to include the new signatureThe new signature calls for the repo setting for wiki formats
| OriginalURLstring`xorm:"VARCHAR(2048)"` | ||
| DefaultBranchstring | ||
| DefaultWikiBranchstring | ||
| DefaultWikiFormatstring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please useRepoUnit to store the per repository configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alright I'll make the changes needed still getting familiar with the codebase apologies.
| DisableMigrations:false, | ||
| DisableStars:false, | ||
| DefaultBranch:"main", | ||
| DefaultWikiFormat:"markdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think we need a global configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It could be useful to have it for cases where you want every repo globally to support both or either upon creation while still leaving the repo owners the freedom to change it.
wxiaoguang commentedNov 28, 2025
TBH, I think it needs a complete design instead of adding more patches. Some edge cases:
And TBH, actually, the legacy wiki file design is quite problematic, including the "escaping" mechanism, they don't work well. If let me re-design the wiki, I'd like to make the path name / wiki title / file name more flexible, and remove all these legacy tricks (avoid unnecessary URL encoding, avoid space and dash hacking, etc). |
Uh oh!
There was an error while loading.Please reload this page.
Resolves#12832
Gitea supports rendering .org files but Wiki does not support pushing .org files and simply ignores them see the issue mentioned for more details.
Editing: Org file on wiki that was pushed
After saving:
The major changes were made to the logic that detects the files pushed to the wiki repo to check for .org files as well as .md files.
If two files with the same name but different extension exist (home.org and home.md for example) .md will take precedence.
Rendering .org worked initially but there was an error hard coded to throw a warning when the detected markup is not markdown and now it uses the detect markup function for the file extension to add support for both .md and .org
This PR currently supports pushing .org files through the git repo for the wiki.