Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Display more configuration options on theadmin/config page.#35962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dangjinghao wants to merge1 commit intogo-gitea:main
base:main
Choose a base branch
Loading
fromdangjinghao:display_more_config

Conversation

@dangjinghao
Copy link

For better readability, display more[mailer] configuration options on theadmin/config page.

  • Display more[mailer] configuration options
  • If an option is not set, it will be hidden
  • DisplayUser option only when SMTP enabled. Because it is only used in SMTP mode
  • Refer to themailer section cheatsheet
  1. dummy mode:
dummy
  1. sendmail mode
image
  1. smtp mode with many options
smtp_with_many_configurations
  1. smtp mode with a few options
smtp_a_few_configurations

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelNov 14, 2025
@github-actionsgithub-actionsbot added modifies/translation modifies/templatesThis PR modifies the template files labelsNov 14, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commentedNov 14, 2025
edited
Loading

There are hundreds of config options.

Without a complete design, the "config" page shouldn't show anything more.


What users really need is to lint the config file and find mistakes, but not read a page which is filled by hundreds of config options again.

dangjinghao reacted with thumbs up emoji

@wxiaoguangwxiaoguang marked this pull request as draftNovember 14, 2025 16:59
@dangjinghao
Copy link
Author

From my testing, theFROM field is required to run dummy and sendmail modes. So I think it would be better to add it.

I've also noticed that theUSER field, which should be exclusive to SMTP, is mistakenly displayed in all modes.

At least, we might want to consider fix both of these.

@wxiaoguang
Copy link
Contributor

wxiaoguang commentedNov 14, 2025
edited
Loading

From my testing, theFROM field is required to run dummy and sendmail modes. So I think it would be better to add it.

You should have been warned, the error log is clearer than the unclear UI. Even if you show FROM on the UI, reader doesn't know that what it should be.

image

I've also noticed that theUSER field, which should be exclusive to SMTP, is mistakenly displayed in all modes.

There are far more mistakes, not only this one. Fixing or not, maybe there is no difference, unless there is a complete design to resolve the problem fundamentally

dangjinghao reacted with thumbs up emoji

@dangjinghao
Copy link
Author

Understood. Thank you for the clarification.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/need 2This PR needs two approvals by maintainers to be considered for merging.modifies/templatesThis PR modifies the template filesmodifies/translation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dangjinghao@wxiaoguang@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp