- Notifications
You must be signed in to change notification settings - Fork49
Feat: Introduce ScopedPatternFilterFactory for Managed, Thread-Safe Filtering#287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
YuyuZha0 wants to merge5 commits intogliwka:mainChoose a base branch fromYuyuZha0:thread-safe-pattern-filter
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@gliwka Could you please help me review this PR? Thank you! |
Thank you for your contribution. I'll take a look over the weekend. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Motivation
The existing
PatternFilterclass is effective for single-threaded use but has two critical limitations in concurrent environments:new PatternFilter()triggers a full Hyperscan database compilation.This forces consumers to implement their own complex and error-prone pooling or
ThreadLocalmanagement to use Hyperscan filtering safely and efficiently in multi-threaded applications like web servers.This PR introduces
ScopedPatternFilterFactoryas a high-level, managed solution that solves these problems out of the box.Key Differences & Improvements
The new
ScopedPatternFilterFactorysupersedes the manualPatternFilterapproach by providing:Thread-Safety by Design: The factory manages a unique, isolated
ScopedPatternFilterinstance for each thread, eliminating the need for external synchronization.High Performance via Caching: The expensive database compilation is performed only once per thread. Subsequent requests for a filter on the same thread reuse the already-compiled instance, drastically improving performance.
Simplified and Safer API: Users interact with a single factory instance and obtain a filter via
try-with-resources (var filter = factory.get()). This returns a proxy that prevents accidental closure of the shared, thread-local resource.Automatic Resource Cleanup: It introduces a robust,
PhantomReference-based mechanism to automatically release native resources for threads that have terminated, preventing memory leaks in dynamic environments.