The work that@ericmorand did in pull request#669 did not fully solve the problem, and also sort of makes it possible to pass invalid objects, so was not a preferred solution. Thanks for leading me in the right direction though@ericmorand!

How was it tested

Loaded in iframe and out of iframe.

Fix issueglidejs#523- "Slider cannot be initialized in iframeglide…

f6b63df

…js#523"

stokesman reviewed

May 18, 2024

View reviewed changes

src/utils/dom.js

Comment on lines +31 to +32

		// We are usine duck-typing here because we can't use `instanceof` since if we're in an iframe the class instance will be different.
		if(node&&node.appendChild&&node.isConnected){

Copy link

stokesmanMay 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree that this seems like a better fix. However, I think it would be possible to avoid duck-typing by usingownerDocument.defaultView. Mostly I'm adding the comment because it seems likeownerDocument anddefaultView are oft overlooked features of the DOM.

Suggested change

	// We are usine duck-typing here because we can't use `instanceof` since if we're in an iframe the class instance will be different.
	if(node&&node.appendChild&&node.isConnected){
	if(!node)returnfalse

	constnodeWindow=node.ownerDocument?.defaultView
	if(nodeWindow&&nodeinstanceofnodeWindow.HTMLElement){

I’d also probably just return the testnodeWindow && node instanceof nodeWindow.HTMLElement directly and eliminate the following returns but couldn’t do that in the scope of the suggestion.