- Notifications
You must be signed in to change notification settings - Fork27
Test Python 3.7 on Ubuntu 22.04, and add Ubuntu 3.13#58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is analogous to the gitdb test workflow and `setup.py` updatesingitpython-developers/gitdb#114.1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available.2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap.3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases.In particular, this change, due to (1), fixes the current CIfailure for smmap observed inf31bfa3.
This is analogous to the 3.7-related CI change in gitdb that waspart ofgitpython-developers/gitdb#114, asto part ofgitpython-developers/smmap#58.Since some tests are not yet passing on 3.13, this does not add3.13 to CI, nor to the documentation of supported versions in`setup.py`. Note that the list there is not enforced; GitPython canalready be installed on Python 3.13 and probably *mostly* works.(Seegitpython-developers#1955for details on other changes that should be made to fully supportrunning GitPython on Python 3.13.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot for your help with this!
I will see to applying similar changes to GitPython as well.
8d0e0bd intogitpython-developers:masterUh oh!
There was an error while loading.Please reload this page.
I'll open a PR in GitPython shortly. |
Ah, great, much appreciated. I just took a quick look and it's different enough to make it far less trivial than I had hoped 😅. |
EliahKagan commentedJan 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
No problem! I've just openedgitpython-developers/GitPython#1987 for this. Edit: Fixed link. |
This is analogous to the gitdb test workflow and
setup.pyupdates ingitpython-developers/gitdb#114.In particular, this change, due to (1), fixes the current CI failure for smmap observed inf31bfa3.
It looks like changes along the lines of (1), in addition to some other changes, will need to be made in GitPython in order to fix some recent breakages in its CI.
This relates to the CI breakages noted in the comment posted ongitpython-developers/GitPython@e51bf80.