NotificationsYou must be signed in to change notification settings
Fork27
Star71

Commita315725

committed

Replace use of mktemp

This uses NamedTemporaryFile with delete=False to replace the oneuse of the deprecated mktemp function in smmap (reported in#41).This avoids the race condition inherent to mktemp, as the file isnamed and created together in a way that is effectively atomic.Because NamedTemporaryFile is not being used to automaticallydelete the file, it use and cleanup are unaffected by the change.

1 parent7d6f97c commita315725Copy full SHA for a315725

File tree

1 file changed

-4

lines changed

smmap/test
- lib.py

1 file changed

-4

lines changed

`‎smmap/test/lib.py`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,12 +18,12 @@ class FileCreator:`
`18`	`18`	`def__init__(self,size,prefix=''):`
`19`	`19`	`assertsize,"Require size to be larger 0"`
`20`	`20`
`21`		`-self._path=tempfile.mktemp(prefix=prefix)`
`22`	`21`	`self._size=size`
`23`	`22`
`24`		`-withopen(self._path,"wb")asfp:`
`25`		`-fp.seek(size-1)`
`26`		`-fp.write(b'1')`
	`23`	`+withtempfile.NamedTemporaryFile("wb",prefix=prefix,delete=False)asfile:`
	`24`	`+self._path=file.name`
	`25`	`+file.seek(size-1)`
	`26`	`+file.write(b'1')`
`27`	`27`
`28`	`28`	`assertos.path.getsize(self.path)==size`
`29`	`29`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita315725

File tree

1 file changed

1 file changed

`‎smmap/test/lib.py`

0 commit comments