correctly handle`uname-cmd` that doesn't point to an executable file#2026

Merged

EliahKagan merged 16 commits intogitpython-developers:mainfrom

gcmarx:main

May 28, 2025

Merged

correctly handle `uname-cmd` that doesn't point to an executable file#2026
EliahKagan merged 16 commits intogitpython-developers:mainfrom
gcmarx:main

Commits

Commits on May 21, 2025

Commits on May 22, 2025

Revert "check for the existence/execute bit on the uname command before trying to run it"
gcmarx
committed
use pathlib.Path instead of os.path.isfile
gcmarx
committed
don't keep checking if sys.platform isn't 'cygwin'
gcmarx
committed
check that uname_cmd points to a file; if uname_cmd were a directory, it could both exist and have os.X_OK but not work
gcmarx
committed
don't use match-case, since it's a 3.10 feature
gcmarx
committed
it's is_file(), not isfile()
gcmarx
committed
turns out f-strings before 3.8 don't support {variable=} notation, take that out
gcmarx
committed

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

correctly handle`uname-cmd` that doesn't point to an executable file#2026

correctly handle `uname-cmd` that doesn't point to an executable file#2026
EliahKagan merged 16 commits intogitpython-developers:mainfrom
gcmarx:main

Commits

Commits on May 21, 2025

add tests for is_cygwin_git

check for the existence/execute bit on the uname command before trying to run it

adding self to authors

Commits on May 22, 2025

Revert "check for the existence/execute bit on the uname command before trying to run it"

use pathlib.Path instead of os.path.isfile

don't keep checking if sys.platform isn't 'cygwin'

check that uname_cmd points to a file; if uname_cmd were a directory, it could both exist and have os.X_OK but not work

don't use match-case, since it's a 3.10 feature

it's is_file(), not isfile()

turns out f-strings before 3.8 don't support {variable=} notation, take that out

Commits on May 27, 2025

add self to AUTHORS, add Emacs tempfiles to .gitignore

use `strings` instead of `uname` to detect cygwin

debug printing

Commits on May 28, 2025

Revert "debug printing"

Revert "use `strings` instead of `uname` to detect cygwin"

incorporate review feedback from @EliahKagan

Movatterモバイル変換

Uh oh!

correctly handle `uname-cmd` that doesn't point to an executable file#2026EliahKagan merged 16 commits intogitpython-developers:maingitpython-developers/GitPython:mainfromgcmarx:maingcmarx/GitPython:mainCopy head branch name to clipboard

Commits

Commits on May 21, 2025

Commits on May 22, 2025

Commits on May 27, 2025

Commits on May 28, 2025

correctly handle `uname-cmd` that doesn't point to an executable file#2026
EliahKagan merged 16 commits intogitpython-developers:mainfrom
gcmarx:main