Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Use WSL1 on CI#2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Use WSL1 on CI#2010
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This avoids an occasional HTTP 403 error updating WSL for WSL2.For details on that issue and possible approaches, see:gitpython-developers#2008 (review)
468f91a intogitpython-developers:main 24 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This avoids an occasional HTTP 403 error updating WSL for WSL2.
Updating WSL2 also takes a bit of time, and this change seems to decrease how long the "Setup WSL" step takes, by about 30 seconds. Both benefits could also be achieved by continuing to use WSL2 but running the Windows jobs on
windows-2025(so long as#2008` is merged). For details on the problem this is fixing and possible approaches to it, see#2008 (review).Due to#2004, the Cygwin test job should be expected to fail here until#2009 is merged. Rebasing this could then make everything pass, but it is only in the non-Cygwin Windows jobs that we ever use WSL, so such a rebase is probably not necessary.