Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Marktest_installation xfail on Cygwin CI#2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Together withgitpython-developers#2007, this works aroundgitpython-developers#2004, allowing all tests topass on Cygwin CI.Ingitpython-developers#2007, installation of the environment in which tests run wasfixed by downloading and running the `get-pip.py` bootstrap script.If we were to modify our helper that sets up the (separate) virtualenvironment in `test_installation` so that it does the same thing(or conditionally does so on CI, since the problem does not seem tohappen in local installations), that would likely "fix" this morethoroughly, allowing the test to pass.But part of the goal of the installation test is to test thatinstallation works in a typical environment on the platform it runson. So it is not obivous that making it pass in that way would bean improvement compared to marking it `xfail` with the exceptiontype that occurs due togitpython-developers#2004. So this just does that, for now.
This was referencedMar 6, 2025
Merged
Thanks a lot for your valuable support.
Generally I am leaning towards closing it to see if a user will submit a related issue. |
d06f8a9 intogitpython-developers:main 24 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Together with#2007, this works around#2004, allowing all tests to pass on Cygwin CI.
In#2007, installation of the environment in which tests run was fixed by downloading and running the
get-pip.pybootstrap script. If we were to modify our helper that sets up the (separate) virtual environment intest_installationso that it does the same thing (or conditionally does so on CI, since the problem does not seem to happen in local installations), that would likely "fix" this more thoroughly, allowing the test to pass.But part of the goal of the installation test is to test that installation works in a typical environment on the platform it runs on. So it is not obivous that making it pass in that way would be an improvement compared to marking it
xfailwith the exception type that occurs due to#2004. So this just does that, for now.I don't know if this should be considered toclose#2004 or not.