Commitf3ab5d3

committed

incorporate review feedback from@EliahKagan

1 parent1731c1e commitf3ab5d3Copy full SHA for f3ab5d3

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -490,7 +490,8 @@ def is_cygwin_git(git_executable: PathLike) -> bool: ...`
`490`	`490`
`491`	`491`
`492`	`492`	`defis_cygwin_git(git_executable:Union[None,PathLike])->bool:`
`493`		`-_logger.debug(f"sys.platform ={sys.platform}, git_executable ={git_executable}")`
	`493`	`+# TODO: when py3.7 support is dropped, use the new interpolation f"{variable=}"`
	`494`	`+_logger.debug(f"sys.platform={sys.platform!r}, git_executable={git_executable!r}")`
`494`	`495`	`ifsys.platform!="cygwin":`
`495`	`496`	`returnFalse`
`496`	`497`	`elifgit_executableisNone:`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -354,6 +354,7 @@ class TestIsCygwinGit:`
`354`	`354`	"""Tests for :func:`is_cygwin_git`"""
`355`	`355`
`356`	`356`	`deftest_on_path_executable(self):`
	`357`	`+# Currently we assume tests run on Cygwin use Cygwin git. See #533 and #1455 for background.`
`357`	`358`	`ifsys.platform=="cygwin":`
`358`	`359`	`assertis_cygwin_git("git")`
`359`	`360`	`else:`

Comments

(0)