Commitd4b50c9

committed

Somewhat clarify multiprocessing misadventure

1 parent602de0c commitd4b50c9Copy full SHA for d4b50c9

File tree

-7

lines changed

-7

lines changed

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -204,11 +204,8 @@ def test_use_shell_cannot_set_on_instance(`
`204`	`204`	`instance.USE_SHELL=value`
`205`	`205`
`206`	`206`
`207`		`-def_check_use_shell_in_worker(value:bool)->None:`
`208`		`-# USE_SHELL should have the value set in the parent before starting the worker.`
`209`		`-assertGit.USE_SHELLisvalue`
`210`		`-`
`211`		`-# FIXME: Check that mutation still works and raises the warning.`
	`207`	`+def_get_value_in_current_process()->bool:`
	`208`	`+returnGit.USE_SHELL`
`212`	`209`
`213`	`210`
`214`	`211`	`@pytest.mark.filterwarnings("ignore::DeprecationWarning")`
`@@ -220,8 +217,8 @@ def test_use_shell_preserved_in_multiprocessing(`
`220`	`217`	`"""The USE_SHELL class attribute pickles accurately for multiprocessing."""`
`221`	`218`	`Git.USE_SHELL=value`
`222`	`219`	`withProcessPoolExecutor(max_workers=1)asexecutor:`
`223`		`-# Calling result() marshals any exception back to this process and raises it.`
`224`		`-executor.submit(_check_use_shell_in_worker,value).result()`
	`220`	`+marshaled_value=executor.submit(_get_value_in_current_process).result()`
	`221`	`+assertmarshaled_valueisvalue`
`225`	`222`
`226`	`223`
`227`	`224`	`_EXPECTED_DIR_SUBSET= {`

Comments

(0)