Commitc1f6c17

committed

Use SystemRoot instead of WINDIR, to fix tox

In most cases they will be the same, but WINDIR may be absent (orhave a different value?) in rare cases.The practical reason it matters in GitPython's tests is that toxautomatically passes SystemRoot through to environments on Windows.

1 parent2b47933 commitc1f6c17Copy full SHA for c1f6c17

File tree

1 file changed

-1

lines changed

test
- test_git.py

1 file changed

-1

lines changed

`‎test/test_git.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ def test_it_executes_git_not_from_cwd(self, rw_dir, case):`
`150`	`150`	`ifos.name=="nt":`
`151`	`151`	`# Copy an actual binary executable that is not git. (On Windows, running`
`152`	`152`	`# "hostname" only displays the hostname, it never tries to change it.)`
`153`		`-other_exe_path=os.path.join(os.getenv("WINDIR"),"system32","hostname.exe")`
	`153`	`+other_exe_path=os.path.join(os.environ["SystemRoot"],"system32","hostname.exe")`
`154`	`154`	`impostor_path=os.path.join(rw_dir,"git.exe")`
`155`	`155`	`shutil.copy(other_exe_path,impostor_path)`
`156`	`156`	`else:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitc1f6c17

File tree

1 file changed

1 file changed

`‎test/test_git.py‎`

0 commit comments