Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
Commitbdfa280
committed
Temporarily let end-of-file-fixer break LICENSE-BSD symlink
On Windows, when `core.symlinks` is `false` or unset (since itdefaults to `false` on Windows), Git checks out symbolic links asregular files whose contents are symlinks' target paths. Modifyingthose regular files and committing the changes alters the symlinktarget in the repository, and when they are checked out as actualsymlinks, the targets are different.But the `end-of-file-fixer` pre-commit hook automatically addsnewlines to the end of regular files that lack them. It doesn't dothis on actual symlinks, but it does do it to regular files thatstand in for symlinks. This causes it to carry a risk of breakingsymlinks if it is run on Windows and the changes committed, and itis easy to miss that this will happen because `git diff` outputshows it the same way as other additions of absent newlines.This deliberately commits the change that end-of-file-fixer makesto the `LICENSE-BSD` symlink, in order to allow a mitigation beyondjust excluding that symlink (or replacing it with a regular file)to be tested. This change must be undone, of course.1 parent53ec790 commitbdfa280
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments
Comments
(0)